"Ask a programmer to review ten lines of code, he’ll find ten issues. Ask him to do five hundred lines, and he’ll say it looks good." - Gene Kim, The DevOps Handbook.
@lucalanziani Recently write about this: lucidsamuel.medium.com/what-is-code-r…
@lucalanziani One of the main reasons to try to break things down in to really small PRs...
@lucalanziani @TusharF5 0 errors spotted in this tweet
@lucalanziani @oferns I prefer another approach. Review the first 500 lines PR thoroughly as usual, and make a comment to avoid PRs like that in the future. If it happens again, I reject it and ask for it to be split into 2 or more pieces. Teams need policies to prevent this stuff
@lucalanziani That's why we encourage to split pull requests up into small, readable - and thus reviewable - commits.
@lucalanziani One time someone sent me a change list with 23k lines of change. I asked if he could break it down to smaller CLs.
@lucalanziani “The length of this document defends it well against the risk of its being read.” — Winston Churchill